Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds newest apiVersion for ingress #278

Closed
wants to merge 2 commits into from
Closed

adds newest apiVersion for ingress #278

wants to merge 2 commits into from

Conversation

rallinator7
Copy link

What was changed

Upgrades web-ingress to be able to use the new apiVersion

Why?

Kubernetes 1.22+ will now have the Ingress object only accessible from networking.k8s.io/v1 not networking.k8s.io/v1beta1.

Checklist

  1. Closes
    [Feature Request] Upgrade ingress-web to use new api version #235
  2. How was this tested:

Tested on

k3d cluster with minimal deployment and ingress enabled

kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.4", GitCommit:"3cce4a82b44f032d0cd1a1790e6d2f5a55d20aae", GitTreeState:"clean", BuildDate:"2021-08-11T18:16:05Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.6+k3s1", GitCommit:"3228d9cb9a4727d48f60de4f1ab472f7c50df904", GitTreeState:"clean", BuildDate:"2022-01-25T01:27:44Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"}
  1. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

robholland
robholland requested changes Jun 8, 2024
View reviewed changes
templates/_helpers.tpl
{{- end -}}

{{/*
Return the target Kubernetes version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to abstract the kubernetes version, just include .Capabilities.KubeVersion.Version where needed.

templates/_helpers.tpl
Return the target Kubernetes version
*/}}
{{- define "temporal.kubeVersion" -}}
{{- default .Capabilities.KubeVersion.Version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a default call with only one value, just include this value directly where it's needed.

@robholland robholland added the needs revision Team has requested some changes label Jun 8, 2024
@robholland robholland mentioned this pull request Jun 15, 2024
Closed
@robholland
Copy link
Contributor

Closing due to inactivity. Please re-open if you'd like to make the requested changes.

@robholland robholland closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robholland robholland robholland requested changes

Assignees
No one assigned
Labels
needs revision Team has requested some changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rallinator7 @CLAassistant @robholland